@aragon999 opened this Pull Request on December 12th 2020 Contributor

Description:

I had a PHP Notice:

PHP Notice:  Trying to access array offset on value of type bool in Filechecks.php:205

while the actual problem was, that I was inside a docker container and had the wrong group-id assigned.

I only had a notice, since the user permissions still worked, but I think that place needs better handling. This PR is a first try to improve the situation.

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on December 15th 2020 Member

I merged this, @aragon999, thanks again for the contribution!

This Pull Request was closed on December 15th 2020
Powered by GitHub Issue Mirror