Improve handling of current user information for Filechecks #16941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
requested changes
Dec 14, 2020
There was a problem hiding this comment.
Thanks for the first contribution @aragon999 ! I requested some changes, but in general I think this change is fine to include given the new logic is only meant to be used if we cannot find a user/group through existing methods. 👍
aragon999
force-pushed
the
refactor/current-user-id-recognition
branch
from
58e4e42
to
873923b
Compare
|
I merged this, @aragon999, thanks again for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I had a PHP Notice:
while the actual problem was, that I was inside a docker container and had the wrong group-id assigned.
I only had a notice, since the user permissions still worked, but I think that place needs better handling. This PR is a first try to improve the situation.
Review