Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better check for getmypid to potentially avoid warnings #16936

Merged
merged 1 commit into from Dec 11, 2020
Merged

Better check for getmypid to potentially avoid warnings #16936

merged 1 commit into from Dec 11, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 11, 2020

Description:

refs https://wordpress.org/support/topic/warning-getmypid-has-been-disabled/

Might not make a difference but could (because third parameter in in_array is not true). This way we might better detect that getmypid is not supported although in the user's case likely the problem is that getmypid is supported in web and not CLI.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur
Better check for getmypid to potentially avoid warnings
a4a4581 
refs https://wordpress.org/support/topic/warning-getmypid-has-been-disabled/

Might not make a difference but could (because third parameter in in_array is not true). This way we might better detect that getmypid is not supported although in the user's case likely the problem is that `getmypid` is supported in web and not CLI.
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 11, 2020
@tsteur tsteur added this to the 4.1.0 milestone Dec 11, 2020
@sgiehl sgiehl merged commit 6c8c118 into 4.x-dev Dec 11, 2020
@sgiehl sgiehl deleted the getmypid branch December 11, 2020 08:01
@tsteur tsteur mentioned this pull request Oct 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @sgiehl