Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some tests exception handling #16932

Merged
merged 1 commit into from Dec 14, 2020
Merged

fix some tests exception handling #16932

merged 1 commit into from Dec 14, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 10, 2020

Description:

The tests actually always passed silently, even though the actually didn't work anymore...

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Dec 10, 2020
@sgiehl sgiehl added this to the 4.1.0 milestone Dec 10, 2020
@diosmosis
Copy link
Member

Is this ready for review?

@sgiehl sgiehl added the Needs Review PRs that need a code review label Dec 11, 2020
@diosmosis diosmosis merged commit 8f980c4 into 4.x-dev Dec 14, 2020
@diosmosis diosmosis deleted the fixtests branch December 14, 2020 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @diosmosis