Rewrite Annotations tests to run correctly #16926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
c: Tests & QA
sgiehl
commented
Dec 9, 2020
Comment on lines
-272
to
+280
| if ($checkException) { | ||
| try { | ||
| $request = new Request($request); | ||
| $request->process(); | ||
| $this->fail($failMessage); | ||
| } catch (Exception $ex) { | ||
| $this->assertTrue(true); // pass | ||
| } | ||
| } else { | ||
| $request = new Request($request); | ||
| $request->process(); | ||
|
|
||
| } | ||
| $request = new Request($request.'&format=original'); | ||
| $request->process(); |
There was a problem hiding this comment.
The requests actually did not contain a format, so xml response was returned. In case of an error there was no exception thrown by the request. But with the meanwhile used PHPUnit version $this->fail() throws an AssertionFailedError exception, which was directly caught and $this->assertTrue(true) did make all tests pass.
Will look through the other tests as well and check where we use $this->fail() in a try/catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The tests actually didn't work anymore and passed silently. Will add some comments to explain that
Review