Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements on prepending a plus sign to evolutions #16923

Merged
merged 2 commits into from Dec 10, 2020
Merged

Improvements on prepending a plus sign to evolutions #16923

merged 2 commits into from Dec 10, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 9, 2020

Description:

When showing evolution (comparison or row evolution) we currently prepend a plus sign to positive evolutions.
This PR improves the handling for that and fixes some issues:

  • Unifies the handling between comparison mode and row evolution
    Having a change of 0 will now always show +0%, before row evolution didn't prepend the +
  • Handle i18n correctly
    Some languages actually don't use a normal + sign for numbers. So use Intl_NumberSymbolPlus instead
  • Current comparison doesn't work on PHP8, causing + sign to be always prepended (refs Run AllTests on PHP8 #16897 )

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added Needs Review PRs that need a code review c: i18n For issues around internationalisation and localisation. labels Dec 9, 2020
@sgiehl sgiehl added this to the 4.1.0 milestone Dec 9, 2020
@diosmosis diosmosis merged commit 848d1a2 into 4.x-dev Dec 10, 2020
@diosmosis diosmosis deleted the plussign branch December 10, 2020 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: i18n For issues around internationalisation and localisation. Needs Review PRs that need a code review
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @diosmosis