Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for webcache.googleusercontent.com #1692

Closed
robocoder opened this issue Sep 11, 2010 · 2 comments
Closed

Support for webcache.googleusercontent.com #1692

robocoder opened this issue Sep 11, 2010 · 2 comments
Assignees
@robocoder
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
1.1

Comments

@robocoder
Copy link
Contributor

There are two considerations here:

  1. when the user clicks on a search result link, he/she is viewing a cached copy of your web page; if the Piwik tracking code is on this page, then Piwik tracks a mangled looking URL
    • we should parse out the original URL and record that instead
  2. the search phrase is embedded in a parameter and has to be parsed out

Pseudo breakdown:

!http://webcache.googleusercontent.com
/search?q=cache:CD2SncROLs4J:piwik.org/blog/2010/04/piwik-0-6-security-advisory/
+piwik+security
&cd=1&hl=en&ct=clnk
@robocoder
Copy link
Contributor Author

(In [3119]) refs #1692 - recognize webcache.googleusercontent.com as a search engine

@robocoder
Copy link
Contributor Author

(In [3120]) fixes #1692 - added Piwik_Common::getUrlRequestVar() -- it is a wrapper around Piwik_Common::getRequestVar("url") and where we apply fix-ups, e.g., for the webcache URL

@robocoder robocoder added this to the Piwik 1.1 milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robocoder robocoder

Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
1 participant
@robocoder