Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct archived metric query for days to conversion #16917

Merged
merged 2 commits into from Dec 9, 2020
Merged

Correct archived metric query for days to conversion #16917

merged 2 commits into from Dec 9, 2020

Conversation

diosmosis
Copy link
Member

Description:

As title.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the Needs Review PRs that need a code review label Dec 9, 2020
@diosmosis diosmosis added this to the 4.0.3 milestone Dec 9, 2020
@diosmosis diosmosis merged commit 1fe1bb3 into 4.x-dev Dec 9, 2020
@diosmosis diosmosis deleted the goals-visitor_days_since_first branch December 9, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.0.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @tsteur