Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More efficient page performance request processor #16913

Merged
merged 1 commit into from Dec 8, 2020
Merged

More efficient page performance request processor #16913

merged 1 commit into from Dec 8, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 8, 2020

Description:

fix #16912

@sgiehl could you look at this one? Should this cause any issues? If so, what would be an alternative fix?

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 8, 2020
@tsteur tsteur added this to the 4.0.3 milestone Dec 8, 2020
sgiehl
sgiehl approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to avoid any queries if no params are given. Haven't tested but if tests pass should be good to merge

@tsteur tsteur merged commit 93f35d9 into 4.x-dev Dec 8, 2020
@tsteur tsteur deleted the M16912 branch December 8, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.x
Development

Successfully merging this pull request may close these issues.

Performance plugin causes select query in request processor
2 participants
@tsteur @sgiehl