Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance plugin causes select query in request processor #16912

Closed
tsteur opened this issue Dec 8, 2020 · 0 comments · Fixed by #16913
Closed

Performance plugin causes select query in request processor #16912

tsteur opened this issue Dec 8, 2020 · 0 comments · Fixed by #16913
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
4.0.x

Comments

@tsteur
Copy link
Member

tsteur commented Dec 8, 2020

Can we maybe first check if there are any request parameters in the request processor before executing a select on every non page view tracking request? This would reduce CPU and load on a DB server quite a bit and make tracking faster.
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Dec 8, 2020
@tsteur tsteur added this to the 4.0.3 milestone Dec 8, 2020
tsteur added a commit that referenced this issue Dec 8, 2020
@tsteur
More efficient page performance request processor
80638ad 
fix #16912
@tsteur tsteur mentioned this issue Dec 8, 2020
Merged
9 tasks
tsteur added a commit that referenced this issue Dec 8, 2020
@tsteur
More efficient page performance request processor (#16913)
93f35d9 
fix #16912
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.x
Development

Successfully merging a pull request may close this issue.

More efficient page performance request processor matomo-org/matomo
2 participants
@tsteur @mattab