Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden check for db-ip urls #16911

Merged
merged 1 commit into from Dec 9, 2020
Merged

Harden check for db-ip urls #16911

merged 1 commit into from Dec 9, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 8, 2020

Description:

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added the Needs Review PRs that need a code review label Dec 8, 2020
@sgiehl sgiehl added this to the 4.1.0 milestone Dec 8, 2020
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Dec 8, 2020
@sgiehl sgiehl merged commit 6d6add4 into 4.x-dev Dec 9, 2020
@sgiehl sgiehl deleted the dbipcheck branch December 9, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @diosmosis