Adds possibility to configure protocols for allowed outgoing connections #16910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
the
c: Security
diosmosis
reviewed
Dec 9, 2020
config/global.ini.php
Outdated
| @@ -719,6 +719,10 @@ | |||
| ; If set to 0 it also disables the "sent plugin update emails" feature in general and the related setting in the UI. | |||
| enable_update_communication = 1 | |||
|
|
|||
| ; This option defines the protocols Matomo's Http class is allowed to open. | |||
| ; If you may need to download GeoIP updates or other stuff using other protocols like ftp you may need to extend this list. | |||
| allowed_protocols = 'http,https' | |||
There was a problem hiding this comment.
Do you think it might be better to name this allowed_outgoing_protocols or similar? To avoid confusion about what it refers to.
diosmosis
reviewed
Dec 9, 2020
diosmosis
approved these changes
Dec 9, 2020
|
@sgiehl seems like there are some test failures |
|
@diosmosis should be fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Matomo should normally not send any request using other protocols than http and https.
In some uncommon use cases it might be needed to send other request. This can be done using a config setting to define the list of allowed protocols.
Review