Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better Windows detection #16901

Merged
merged 2 commits into from Dec 10, 2020
Merged

better Windows detection #16901

merged 2 commits into from Dec 10, 2020

Conversation

Findus23
Copy link
Member

@Findus23 Findus23 commented Dec 7, 2020

Not related to any actual issue, but I just came across this constant which should be more reliable and now with PHP 7.2 available for everyone.

PHP_OS_FAMILY (string)

The operating system family PHP was built for. One of 'Windows' , 'BSD' , 'Darwin' , 'Solaris' , 'Linux' or 'Unknown' . Available as of PHP 7.2.0.
https://www.php.net/manual/en/reserved.constants.php

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added the Needs Review PRs that need a code review label Dec 7, 2020
@tsteur tsteur added this to the 4.1.0 milestone Dec 7, 2020
diosmosis
diosmosis approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test, but looks good

@diosmosis diosmosis merged commit 7ff1e6c into 4.x-dev Dec 10, 2020
@diosmosis diosmosis deleted the real-windows-detection branch December 10, 2020 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl left review comments

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Findus23 @diosmosis @sgiehl @tsteur