Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates device detector to 4.0.2 #16900

Merged
merged 5 commits into from Dec 7, 2020
Merged

updates device detector to 4.0.2 #16900

merged 5 commits into from Dec 7, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 7, 2020

Description:

fixes #16889

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added this to the 4.0.3 milestone Dec 7, 2020
@sgiehl
Copy link
Member Author

sgiehl commented Dec 7, 2020 •
edited

@Findus23 could you add an icon for the device type peripheral. It combines stuff like printers, cash bins, refrigerators and stuff like that. So maybe the printer icon would be fine.

@sgiehl sgiehl marked this pull request as ready for review December 7, 2020 14:53
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. labels Dec 7, 2020
@sgiehl sgiehl merged commit 28efeaf into 4.x-dev Dec 7, 2020
@sgiehl sgiehl deleted the ddup branch December 7, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
4.0.x
Development

Successfully merging this pull request may close these issues.

AbstractDeviceParser::getShortCode() must be of the type string, int returned
1 participant
@sgiehl