Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host detection: use HTTP_HOST as default, but provide a setting to use SERVER_NAME instead #16899

Merged
merged 4 commits into from Dec 7, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 7, 2020

Description:

refs #16866

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added this to the 4.0.3 milestone Dec 7, 2020
@sgiehl sgiehl marked this pull request as ready for review December 7, 2020 11:23
@sgiehl sgiehl added the Needs Review PRs that need a code review label Dec 7, 2020
@sgiehl sgiehl requested a review from tsteur December 7, 2020 11:23
@tsteur tsteur merged commit 0d97901 into 4.x-dev Dec 7, 2020
@tsteur tsteur deleted the servernameconfig branch December 7, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants