Only invalidate in past for segments that belong to the site … #16896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… process an invalidation if it is for a site + we can load the segment
diosmosis
added
the
not-in-changelog
sgiehl
requested changes
Dec 7, 2020
| try { | ||
| $segmentObj = new Segment($segment['definition'], [$idSite]); | ||
| } catch (\Exception $ex) { | ||
| $this->logger->debug("Could not process segment {$segment['definition']} for site {$idSite}. Segment should not exist for the site, but does."); |
There was a problem hiding this comment.
The debug message confuses me. Isn't an exception thrown when the segment does not exist?
Also this case shouldn't occur at all if the isSegmentForSite works correctly, right?
There was a problem hiding this comment.
It shouldn't occur, but if it does it would break archiving, and I didn't think that needed to happen. This is a sanity check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
… and only process an invalidation if it is for a site + we can load the segment
Fixes #16892
FYI @tsteur
Review