@tsteur opened this Pull Request on December 6th 2020 Member

fix https://github.com/matomo-org/matomo/issues/16885

It was basically an array like array('idarchive'=> '', '', ...) when it should be [1,'name']

Wondering though if the better fix would be in https://github.com/matomo-org/matomo/blob/4.0.4/core/DataAccess/Model.php#L228-L237 to make sure it's a regular array there?

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on December 6th 2020 Member

Wondering though if the better fix would be in https://github.com/matomo-org/matomo/blob/4.0.4/core/DataAccess/Model.php#L228-L237 to make sure it's a regular array there?

No opinion on this personally, seems like if we ignore the keys anyway this fix is fine

This Pull Request was closed on December 6th 2020
Powered by GitHub Issue Mirror