Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ArgumentCountError: mysqli_stmt::bind_param() does not accept unknown named parameters #16893

Merged
merged 1 commit into from Dec 6, 2020
Merged

Fix ArgumentCountError: mysqli_stmt::bind_param() does not accept unknown named parameters #16893

merged 1 commit into from Dec 6, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 6, 2020

fix #16885

It was basically an array like array('idarchive'=> '', '', ...) when it should be [1,'name']

Wondering though if the better fix would be in https://github.com/matomo-org/matomo/blob/4.0.4/core/DataAccess/Model.php#L228-L237 to make sure it's a regular array there?

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 6, 2020
@tsteur tsteur added this to the 4.0.3 milestone Dec 6, 2020
@diosmosis diosmosis merged commit bfce7cd into 4.x-dev Dec 6, 2020
@diosmosis diosmosis deleted the m16885 branch December 6, 2020 23:31
@diosmosis
Copy link
Member

Wondering though if the better fix would be in https://github.com/matomo-org/matomo/blob/4.0.4/core/DataAccess/Model.php#L228-L237 to make sure it's a regular array there?

No opinion on this personally, seems like if we ignore the keys anyway this fix is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.x
Development

Successfully merging this pull request may close these issues.

named parameters in mysqli_stmt->bind_param
2 participants
@tsteur @diosmosis