Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check only invalidations created for correct sites #16892

Closed
tsteur opened this issue Dec 6, 2020 · 0 comments · Fixed by #16896
Closed

Check only invalidations created for correct sites #16892

tsteur opened this issue Dec 6, 2020 · 0 comments · Fixed by #16896
Assignees
@diosmosis
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.0.x

Comments

@tsteur
Copy link
Member

tsteur commented Dec 6, 2020

We have a customer that reports this:

Piwik\Segment->__construct(dimension17==DE, Array ([0] => 1)) - that looks like Matomo is trying to load a segment from another idSite for Site 1, which will fail because idSite1 does not have a dimension17.

image

Here is the backtrace:

[32mINFO [2020-12-05 15:30:25] 8485 �[39m Start processing archives for site 1.
#0  Piwik\Segment->getSegmentByName(dimension17) called at [core/Segment.php:258]
#1  Piwik\Segment->getExpressionsWithUnionsResolved(Array ([0] => Array ([0] => ,[1] => Array ([0] => dimension17,[1] => ==,[2] => DE)))) called at [core/Segment.php:236]
#2  Piwik\Segment->initializeSegment(dimension17==DE, Array ([0] => 1)) called at [/var/app/current/core/Segment.php:145]
#3  Piwik\Segment->__construct(dimension17==DE, Array ([0] => 1)) called at [core/CronArchive/SegmentArchiving.php:128]
#4  Piwik\CronArchive\SegmentArchiving->findSegmentForHash(90a5a511e1974bca37613b6daec137ba, 1) called at [core/CronArchive/QueueConsumer.php:472]
#5  Piwik\CronArchive\QueueConsumer->findSegmentForArchive(Array ([idinvalidation] => 210,[idarchive] => ,[idsite] => 1,[date1] => 2020-12-04,[date2] =>

@diosmosis can you check if it's possible that we invalidate entries for a segment for a wrong site somehow?

That's using 4.0.4
@tsteur tsteur added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Dec 6, 2020
@tsteur tsteur added this to the 4.0.3 milestone Dec 6, 2020
@diosmosis diosmosis self-assigned this Dec 6, 2020
@diosmosis diosmosis mentioned this issue Dec 7, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.0.x
Development

Successfully merging a pull request may close this issue.

Only invalidate in past for segments that belong to the site … matomo-org/matomo
2 participants
@diosmosis @tsteur