Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version available plugins will be updated confusing #16890

Merged
merged 1 commit into from Dec 10, 2020
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 6, 2020

We've had 3 issues where people thought that a plugin is not compatible with Matomo 4 because of this screen that is misleading as it shows the current plugin dependencies:
image

For simplicity lets simply only show the name of the plugin as mostly plugins are only compatible with the same major version number anyway and there isn't much value in showing the current required information. Of course we could check if there is actually a version on the marketplace available etc but it would require more work.

refs matomo-org/plugin-LoginLdap#221

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

We've had 3 issues where people thought that a plugin is not compatible with Matomo 4 because of this screen that is misleading as it shows the current plugin dependencies:
![image](https://user-images.githubusercontent.com/273120/101269833-c6ef4d00-37d7-11eb-8df1-755686435938.png)


For simplicity lets simply only show the name of the plugin as mostly plugins are only compatible with the same major version number anyway and there isn't much value in showing the current required information. Of course we could check if there is actually a version on the marketplace available etc but it would require more work.
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 6, 2020
@tsteur tsteur added this to the 4.1.0 milestone Dec 6, 2020
@diosmosis diosmosis merged commit 161af3f into 4.x-dev Dec 10, 2020
@diosmosis diosmosis deleted the meo339 branch December 10, 2020 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants