@diosmosis opened this Pull Request on December 5th 2020 Member

Description:

In case the archive_invalidations table ends up in an inconsistent state, make sure we process invalidations higher than what we find.

cc @tsteur

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@tsteur commented on December 6th 2020 Member

@sgiehl be great if you could review this tomorrow. We'd probably need to merge this at the same time as https://github.com/matomo-org/matomo/pull/16843 to fully avoid too many duplicates.

@diosmosis commented on December 8th 2020 Member

@tsteur updated, there are still tests for it, but some of the effects seen in the queue consumer tests are no longer there

@tsteur commented on December 8th 2020 Member

Otherwise good to merge once the other comment re the where clause is resolved and tests pass

This Pull Request was closed on December 8th 2020
Powered by GitHub Issue Mirror