Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page generation time not being tracked after 4.x upgrade #16884

Closed
HatBeardZero opened this issue Dec 4, 2020 · 7 comments
Closed

Page generation time not being tracked after 4.x upgrade #16884

HatBeardZero opened this issue Dec 4, 2020 · 7 comments
Labels
answered For when a question was asked and we referred to forum or answered it.

Comments

@HatBeardZero
Copy link

I updated my instance from 3.14.0 to 4.0.4 and now page generation time is not being tracked.

Any thoughts on what could cause this?

@tsteur
Copy link
Member

tsteur commented Dec 4, 2020

Hi @HatBeardZero we have removed this feature in Matomo 4 and replaced it with the new page performance reports see https://matomo.org/faq/how-to/how-do-i-see-page-performance-reports/ So this is expected and we're now tracking more detailed insights.

@tsteur tsteur closed this as completed Dec 4, 2020
@tsteur tsteur added the answered For when a question was asked and we referred to forum or answered it. label Dec 4, 2020
@HatBeardZero
Copy link
Author

it still shows up on the report pages though under visits overview on the dashboard, and visits->overview

@tsteur
Copy link
Member

tsteur commented Dec 4, 2020

@HatBeardZero it still shows it so you can still view previously tracked data.

@sgiehl do we remove the column for dates after the upgrade to Matomo 4 (not too important but could avoid confusion)

@fvdm
Copy link

fvdm commented Dec 5, 2020

@tsteur I love the new performance stats, but also like to keep the old metrics for comparison over time. Can't the old data be merged with 'Avg. page load time' ?

@sgiehl
Copy link
Member

sgiehl commented Dec 5, 2020

@tsteur the metric should actually be removed automatically if the sum of page generation times is 0. See

public function beforeCompute($report, DataTable $table)
{
$hasTimeGeneration = array_sum($this->getMetricValues($table, 'sum_time_generation')) > 0;
if (!$hasTimeGeneration
&& $table->getRowsCount() != 0
&& !$this->hasAverageTimeGeneration($table)
) {
// No generation time: remove it from the API output and add it to empty_columns metadata, so that
// the columns can also be removed from the view
$table->filter('ColumnDelete', array(array(
Metrics::INDEX_PAGE_SUM_TIME_GENERATION,
Metrics::INDEX_PAGE_NB_HITS_WITH_TIME_GENERATION,
Metrics::INDEX_PAGE_MIN_TIME_GENERATION,
Metrics::INDEX_PAGE_MAX_TIME_GENERATION,
'sum_time_generation',
'nb_hits_with_time_generation',
'min_time_generation',
'max_time_generation'
)));
if ($table instanceof DataTable) {
$emptyColumns = $table->getMetadata(DataTable::EMPTY_COLUMNS_METADATA_NAME);
if (!is_array($emptyColumns)) {
$emptyColumns = array();
}
$emptyColumns[] = 'sum_time_generation';
$emptyColumns[] = 'avg_time_generation';
$emptyColumns[] = 'min_time_generation';
$emptyColumns[] = 'max_time_generation';
$table->setMetadata(DataTable::EMPTY_COLUMNS_METADATA_NAME, $emptyColumns);
}
}
Not sure if that actually work correctly.

@fvdm Guess we could merge them. But actually they are not that good comparable in most cases. Guess most people tracked the time the server needed to generate the response. The new page performace metrics are also including timtings for network and browser rendering, which likely were not included before...

@peterbo
Copy link
Contributor

peterbo commented Dec 9, 2020

It's probably still included in the graph selectors or will the list of selectable metrics also get filtered then? In general (sorry for hijacking this issue), it'd be great to have the avg. page load time also as a graph plottable metric as a successor of the avg. page generation time.

@mattab
Copy link
Member

mattab commented Dec 23, 2020

It's probably still included in the graph selectors or will the list of selectable metrics also get filtered then? In general (sorry for hijacking this issue), it'd be great to have the avg. page load time also as a graph plottable metric as a successor of the avg. page generation time.

@peterbo thanks for the suggestion! created follow-up issue #17010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Development

No branches or pull requests

6 participants