Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load correct url for multisites when clicked in site selector #16883

Merged
merged 1 commit into from Dec 10, 2020
Merged

Load correct url for multisites when clicked in site selector #16883

merged 1 commit into from Dec 10, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 4, 2020

Description:

As MultiSites dashboard should not be loaded with any additional parameters we should not load it using propagateNewPage, as that manipulates the hash only. Simply changing the location should be fine in this case.

fixes #16879

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Dec 4, 2020
@tsteur tsteur added this to the 4.1.0 milestone Dec 4, 2020
@diosmosis diosmosis merged commit 4451622 into 4.x-dev Dec 10, 2020
@diosmosis diosmosis deleted the fixmultisitelink branch December 10, 2020 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

Hide Comparison feature on All Websites dashboard
3 participants
@sgiehl @diosmosis @tsteur