New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds missing report documentations #16878
Conversation
3d023ee
to
e2c2770
Compare
e2c2770
to
c048105
Compare
1ecc15b
to
eb0bc9b
Compare
Would be good if someone else could look through the documentations I've added and maybe improve them further. Didn't spent too much time on thinking of good descriptions. Also some of the dynamically created reports currently don't have a documentation, like the custom dimension reports. Not sure if we should add one there as well. And we need to check all our plugins as well maybe |
@mattab maybe we could have Daniel, the person rewriting our technical guides, to look over these docs later? For now we could merge after checking for small errors, then they could look through the UI and make tweaks to the report documentation w/o having to look through code. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some simple spellchecking
I think spending time making the report docs perfect here is probably time ill-spent, so I'll do some quick checks for typos and create a new issue to revise the report docs in the future. If that must be done in 4.1, it can be prioritized there. |
Be great to do it as part of 4.1 👍 |
@sgiehl I made some revisions to some of the docs, can you check if they sound better to you? Feel free to revert any changes I made. |
@diosmosis the changes look good. If noone else does one to take a look, it might be good to merge. |
Description:
This also fixes an issue where the report documentation was not visible after switching to a related report.
fixes #16792
Review