@sgiehl opened this Pull Request on December 3rd 2020 Member

Description:

refs #16867

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@tsteur commented on December 3rd 2020 Member

Worked for me generally. However, the visitor map UI tests are now failing. And when I'm on the widgetized page then I always get an error "failed to login"

image
image

I'll push a fix for this and will quickly look into visitor map issue.

Generally I think there might be still an issue though in general if someone was to embed any non widget action using a regular token auth?

@tsteur commented on December 3rd 2020 Member

I'm expecting the tests to pass and will likely merge to have it fixed for widgets. I'll add a comment to the original issue to next check it what happens when embedding other actions directly if there is any issue (such as Goals.manageGoals) or the entire UI etc

This Pull Request was closed on December 3rd 2020
Powered by GitHub Issue Mirror