Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use existing Request method w/ correct logic for limiting widgetize access. #16871

Merged
merged 1 commit into from Dec 3, 2020
Merged

Use existing Request method w/ correct logic for limiting widgetize access. #16871

merged 1 commit into from Dec 3, 2020

Conversation

diosmosis
Copy link
Member

Description:

FYI @tsteur

Fixes #16869

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 2, 2020
@diosmosis diosmosis added this to the 4.0.3 milestone Dec 2, 2020
@tsteur
Copy link
Member

tsteur commented Dec 3, 2020

Works 👍

@tsteur tsteur merged commit ba9d657 into 4.x-dev Dec 3, 2020
@tsteur tsteur deleted the 16869-widgetize-controller branch December 3, 2020 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.x
Development

Successfully merging this pull request may close these issues.

Widget access always only works with view access not respecting new config setting
2 participants
@diosmosis @tsteur