Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document setGenerationTime removal and add back the method #16860

Merged
merged 2 commits into from Dec 2, 2020
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 2, 2020

Description:

fix #16853

created #16859 as a follow up

for now it's just important to have this method again in the JS tracker as it otherwise can cause errors

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 2, 2020
@tsteur tsteur added this to the 4.0.3 milestone Dec 2, 2020
@diosmosis
Copy link
Member

build js

@diosmosis diosmosis merged commit adbe14c into 4.x-dev Dec 2, 2020
@diosmosis diosmosis deleted the m16853 branch December 2, 2020 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing setGenerationTimeMs after upgrade to 4.x
2 participants