Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing setGenerationTimeMs after upgrade to 4.x #16853

Closed
HollyPony opened this issue Dec 1, 2020 · 4 comments · Fixed by #16860
Closed

Missing setGenerationTimeMs after upgrade to 4.x #16853

HollyPony opened this issue Dec 1, 2020 · 4 comments · Fixed by #16860
Assignees
Labels
c: Documentation For issues related to in-app product help messages, or to the Matomo knowledge base. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@HollyPony
Copy link

According to the changelog there is no mentions of this breaking change that was required following documentation of 3.x .

I can see there was some "optimization" undocumented (mainly deleted doc).

Could I have more informations about why it was deleted and how to safely do elsething ?

@tsteur tsteur transferred this issue from matomo-org/developer-documentation Dec 1, 2020
@tsteur tsteur added this to the 4.0.3 milestone Dec 1, 2020
@tsteur tsteur added the c: Documentation For issues related to in-app product help messages, or to the Matomo knowledge base. label Dec 1, 2020
@tsteur
Copy link
Member

tsteur commented Dec 1, 2020

This seems to be missing from the changelog indeed. Thanks for mentioning it @HollyPony

To fix this issue we need to mention the removal in the developer changelog.

It was removed because the generation time feature was replaced by the new performance feature in Matomo 4. You can see the more granular/detailed performance metrics now in Behaviour -> Performance report. There is currently no replacement. Do you maybe have a single page application or what do you need the method for?

@HollyPony
Copy link
Author

To fix this issue we need to mention the removal in the developer changelog.

So, the removal is f8dfb50 from PR #15736

Do you maybe have a single page application or what do you need the method for?

Yes, I'm maintaining an old angularjs 1 app so ... 🤷 and to be honest I just followed the doc so I'm not sure if it's really relevant to continue using setGenerationTimeMs in my case. I really don't know I'm just surprise.

Nb. I noticed that due to my usage as tracker.setGenerationTimeMs() nor the paq.push("blabla") then my console crashed.

The fact is, I just don't know if it's simply "ok" to remove that or if I should investigate new purposes about SPAs integrations

@tsteur tsteur added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Dec 2, 2020
@tsteur
Copy link
Member

tsteur commented Dec 2, 2020

As part of this issue we'll also add back the tracker method and trigger a console error that this method is now no longer working or so.

@sgiehl can you look into this tomorrow?

@tsteur tsteur self-assigned this Dec 2, 2020
@tsteur
Copy link
Member

tsteur commented Dec 2, 2020

fyi created #16859

@tsteur tsteur added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Documentation For issues related to in-app product help messages, or to the Matomo knowledge base. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants