@diosmosis opened this Pull Request on December 1st 2020 Member

Description:

TTL check did subSeconds(1) for some odd reason. Note: @tsteur there didn't seem to be an issue w/ the ttl check that happens before invalidating, so if that was the problem you were experiencing, I couldn't reproduce it.

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@tsteur commented on December 2nd 2020 Member

@diosmosis worked for me 👍 . Was going to merge it but noticed a test is failing. Can you check out https://travis-ci.com/github/matomo-org/matomo/jobs/452063651#L846 and then merge it?

This Pull Request was closed on December 2nd 2020
Powered by GitHub Issue Mirror