Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The parameter ‘confirmPassword’ isn’t set in the Request #16847

Closed
Findus23 opened this issue Dec 1, 2020 · 4 comments · Fixed by #16849
Closed

The parameter ‘confirmPassword’ isn’t set in the Request #16847

Findus23 opened this issue Dec 1, 2020 · 4 comments · Fixed by #16849
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
4.5.0

Comments

@Findus23
Copy link
Member

Findus23 commented Dec 1, 2020

reported in https://forum.matomo.org/t/warning-message-on-new-installation/39557/3 (futher down)

I do however have an issue trying to install the google analytics plugin as i get this server error either trying to access the marketplace or import a zip file. Any ideas on that one? From what I read in the other article, it seems the issues may have been related?

( 500 - Internal server error. ### There is a problem with the resource you are looking for, and it cannot be displayed.)

ERROR Piwik\ExceptionHandler[2020-12-01 11:04:09 UTC] [ffda2] Uncaught exception: C:\inetpub\wwwroot\matomo\core\Common.php(535): The parameter ‘confirmPassword’ isn’t set in the Request, and a default value wasn’t provided.
ERROR Piwik\ExceptionHandler[2020-12-01 11:04:09 UTC] [ffda2] The parameter ‘confirmPassword’ isn’t set in the Request, and a default value wasn’t provided.

matomo/core/Common.php

Line 535 in f4dd562

throw new Exception("The parameter '$varName' isn't set in the Request, and a default value wasn't provided.");

This is most likely called from

matomo/plugins/CorePluginsAdmin/Controller.php

Line 120 in 7585967

Common::getRequestVar('confirmPassword', null, 'string')

@Findus23 Findus23 added this to the 4.0.3 milestone Dec 1, 2020
@sgiehl
Copy link
Member

sgiehl commented Dec 1, 2020

I'm able to reproduce that locally. Seems the form data is actually not send with the request. Will look into it.

@sgiehl sgiehl self-assigned this Dec 1, 2020
@Findus23 Findus23 added the Bug For errors / faults / flaws / inconsistencies etc. label Dec 1, 2020
@sgiehl
Copy link
Member

sgiehl commented Dec 1, 2020

Guess that might be an issue of post_max_size php ini setting being too low. The plugin has 12 MB, but the default setting has 8M. Will create a simple PR that shows an error when someone wants to upload a file that is bigger than post_max_size.
But guess that's nothing we need for 4.0.3, so moving out of the milestone for now

@sgiehl sgiehl removed this from the 4.0.3 milestone Dec 1, 2020
@sgiehl sgiehl mentioned this issue Dec 1, 2020
Merged
9 tasks
@tsteur
Copy link
Member

tsteur commented Dec 1, 2020

Could we in general simply check if that parameter is missing and if so, indicate that likely they need to increase post_max_size or install plugin through the marketplace instead of adjusting a plugin?

@tsteur tsteur added this to the 4.0.3 milestone Dec 1, 2020
@tsteur
Copy link
Member

tsteur commented Dec 1, 2020

I see there's already a PR now

@tsteur tsteur modified the milestones: 4.0.3, 4.2.0, 4.3.0 Dec 3, 2020
@mattab mattab modified the milestones: 4.7.0, 4.5.0 Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
4.5.0
Development

Successfully merging a pull request may close this issue.

Don't accept files that are bigger than the upload limit when uploading plugins matomo-org/matomo
4 participants
@tsteur @mattab @sgiehl @Findus23