Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message when fopen fails in Http class #16846

Merged
merged 2 commits into from Dec 10, 2020
Merged

Fix error message when fopen fails in Http class #16846

merged 2 commits into from Dec 10, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 1, 2020

Description:

error_get_last does not work anymore on PHP 7 when using a custom error handler.
Created ErrorHandler::getLastError to achieve the same with our custom handler.

fixes #15850

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Dec 1, 2020
@sgiehl sgiehl added this to the 4.1.0 milestone Dec 1, 2020
@diosmosis diosmosis merged commit 06918ee into 4.x-dev Dec 10, 2020
@diosmosis diosmosis deleted the fopenfix branch December 10, 2020 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.1.0
2 participants
@sgiehl @diosmosis