New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
segment invalidations must be paired w/ normal invalidations #16845
Conversation
@diosmosis just tested it. I think there's one issue for it. If the archive TTL for today is set to for example 900s. And if it has found an archive for the Not sure if it's clear what I mean? I haven't checked but I think you can reproduce this by having eg a TTL of 900s. Then call If you then call it with |
@diosmosis I just tested it but for some reason it's now not even triggering the main archive. Even though the last archive is older than the TTL of 30s and there is a recent tracking request
It might be unrelated to this issue though? The site's timezone is "auckland" and there is definitely a very recent visit |
I'll try to have a quick debug. I would have actually expected to have an entry for
|
Invalidation table itself is empty |
@diosmosis I think the method |
I'm not sure what's wrong but for |
@tsteur updated for timezone issue |
Works now @diosmosis Thanks! 👍 Was wondering if we can maybe write a test that for this recent change 52e4ea3#diff-f41c275e883996b8b69cb765b1818e12e82cbe034e648bc3f7d03610cc7abad1R843 that it uses the right date but I suppose it might be bit difficult. Might work though with a mock and checking what it passes to |
@tsteur added a test and fixed existing tests |
@diosmosis LGTM. There still seems to be a failing test though? |
Description:
Previously segments were procedurally archived after others, now we need to invalidate them for the QueueConsumer to pick them up.
Fixes #16842
Review