Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only select invalidations that were added before a sites archiving began #16844

Merged
merged 2 commits into from Dec 2, 2020

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Dec 1, 2020

Description:

To avoid potential delays in finishing archiving we only handle invalidations that were added before archiving for a specific site begins.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the Needs Review PRs that need a code review label Dec 1, 2020
@diosmosis diosmosis added this to the 4.0.3 milestone Dec 1, 2020
@sgiehl
Copy link
Member

sgiehl commented Dec 1, 2020

@diosmosis there's a test failing. Otherwise the codes looks imho good.

@tsteur tsteur merged commit 32ed3a8 into 4.x-dev Dec 2, 2020
@tsteur tsteur deleted the archive-invalidation-limit branch December 2, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants