Fix unknown keyword is not shown in transitions report in seach engines section #16841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this isn't tested by an existing system test, should we add one? |
|
@diosmosis no tests failed so it's likely not covered. We could add a test but am quite busy and don't really have time to add one and figured at least it'll be fixed. Better than not having it fixed. I reckon ideally there was a test but it's also not crazy important. |
|
@tsteur this is in the 4.1.0 milestone so I think someone could add it later on if there was time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Transitions report currently doesn't show the Unknown keyword and therefore the percentages for search keywords are completely wrong. Basically if there are 700 searches, and 5 times the keywords were detected from the search, then it calculates the percentage based on the 5 detected keywords. If 5 keywords were used once, then each keyword gets shown 20% and to the user it looks like 20% of 700 searches.
Review