@diosmosis there was a problem with
That method actually never worked correctly for some cases. It was searching the url for
param + '=' or
param + '=', which was actually not correct in some cases.
As soon as the request param name was included in another param the method actually returned the wrong value.
Let's assume a url like
broadcast.getParamValue('param') would actually have returned
1 instead of
2. That behavior actually caused the test failures as
category and so the wrong value was returned.
I've changed the method so it hopefully should work correct now. Let's see if all tests are still passing...
@sgiehl given the method was buggy, do you think it might help to have angular unit tests for this method in broadcast?
@sgiehl one screenshot test failure needs to be looked at: https://builds-artifacts.matomo.org/matomo-org/matomo/invaliddate/44416/PeriodSelector_invalid.png then it's good to merge i'd say
@sgiehl there appear to be two more comparison related test failures