Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve php8 compatibility #16838

Merged
merged 1 commit into from Nov 30, 2020
Merged

Improve php8 compatibility #16838

merged 1 commit into from Nov 30, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 30, 2020

Description:

fix #16828

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 30, 2020
@tsteur tsteur added this to the 4.0.3 milestone Nov 30, 2020
@tsteur tsteur merged commit fc2e8a5 into 4.x-dev Nov 30, 2020
@tsteur tsteur deleted the m16828 branch November 30, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.x
Development

Successfully merging this pull request may close these issues.

never specify optional parameter before required one
1 participant
@tsteur