@diosmosis opened this Pull Request on November 30th 2020 Member

…a site is deleted + tweaks to some debug logs

Description:

Deleted some sites while a canceled/failed archive had been run before, and the next core:archive run would keep failing since the sites in the list didn't exist. Added some more checks for whether the site exists or not and fixed the existing check method.

FYI @tsteur

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@tsteur commented on November 30th 2020 Member

Looks generally good once tests pass @diosmosis 👍 there are a few comments to look at and a merge conflict but nothing major.

@diosmosis commented on December 1st 2020 Member

@tsteur @sgiehl found a simpler solution that will avoid extra queries

This Pull Request was closed on December 2nd 2020
Powered by GitHub Issue Mirror