@tsteur opened this Pull Request on November 29th 2020 Member

refs https://github.com/matomo-org/matomo/pull/16835#issuecomment-735466614

fyi @sgiehl

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@mattab commented on November 29th 2020 Member
@sgiehl commented on November 30th 2020 Member

@mattab 1500 bytes is actually not correct I guess. It's a VARCHAR(1500) so there are 1500 characters allowed. Depending on the collation one character can have up to 3 or 4 bytes. Might be better to write characters instead maybe

@mattab commented on December 6th 2020 Member

@sgiehl sounds good! updated to this:
Screenshot from 2020-12-07 09-47-05

@tsteur commented on December 6th 2020 Member

@mattab as mentioned in slack by default the referrer page url is also limited to 1024 characters but can be increased to 1500 through the same setting.

This Pull Request was closed on November 30th 2020
Powered by GitHub Issue Mirror