Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim referrer url if needed #16836

Merged
merged 3 commits into from Nov 30, 2020
Merged

Trim referrer url if needed #16836

merged 3 commits into from Nov 30, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 29, 2020

refs #16835 (comment)

fyi @sgiehl

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 29, 2020
@tsteur tsteur added this to the 4.0.3 milestone Nov 29, 2020
@mattab
Copy link
Member

mattab commented Nov 29, 2020

fyi added to https://matomo.org/docs/data-limits/
Screenshot from 2020-11-30 11-53-34

@tsteur tsteur merged commit bbf8888 into 4.x-dev Nov 30, 2020
@tsteur tsteur deleted the trimrefurl branch November 30, 2020 01:13
@sgiehl
Copy link
Member

sgiehl commented Nov 30, 2020

@mattab 1500 bytes is actually not correct I guess. It's a VARCHAR(1500) so there are 1500 characters allowed. Depending on the collation one character can have up to 3 or 4 bytes. Might be better to write characters instead maybe

@mattab
Copy link
Member

mattab commented Dec 6, 2020

@sgiehl sounds good! updated to this:
Screenshot from 2020-12-07 09-47-05

@tsteur
Copy link
Member Author

tsteur commented Dec 6, 2020

@mattab as mentioned in slack by default the referrer page url is also limited to 1024 characters but can be increased to 1500 through the same setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants