Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change referrer url size to 1500 #16835

Merged
merged 1 commit into from Nov 29, 2020
Merged

Change referrer url size to 1500 #16835

merged 1 commit into from Nov 29, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 29, 2020

fix #16810

Avoids running into row size exceeded in some cases.

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

refs #16810

Avoids running into row size exceeded in some cases.
@tsteur tsteur added the Needs Review PRs that need a code review label Nov 29, 2020
@tsteur tsteur added this to the 4.0.3 milestone Nov 29, 2020
@tsteur
Copy link
Member Author

tsteur commented Nov 29, 2020

Tests pass so I'll merge this fyi @sgiehl @diosmosis

@tsteur tsteur merged commit 394a9f5 into 4.x-dev Nov 29, 2020
@tsteur tsteur deleted the referrer_urlsize branch November 29, 2020 22:15
@sgiehl
Copy link
Member

sgiehl commented Nov 29, 2020

@tsteur should we trim the referer url to that length before storing it? otherwise it might fail when a database runs in strict mode but the referer was actually longer...

@tsteur
Copy link
Member Author

tsteur commented Nov 29, 2020

@sgiehl sure I'll add this in a bit

tsteur added a commit that referenced this pull request Nov 29, 2020
@tsteur tsteur mentioned this pull request Nov 29, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matomo 4 migration: Row size too large
2 participants