Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore errors while updating session ids #16829

Merged
merged 1 commit into from Nov 27, 2020
Merged

Ignore errors while updating session ids #16829

merged 1 commit into from Nov 27, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 27, 2020

Description:

we could also check each key for duplicate before inserting it, but guess it's not worth the effort, as in worst case someone get logged out only

refs #16824

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 27, 2020
@sgiehl sgiehl added this to the 4.0.2 milestone Nov 27, 2020
@tsteur tsteur merged commit 3cb1d54 into 4.x-dev Nov 27, 2020
@tsteur tsteur deleted the fixsessionupdate branch November 27, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants