@sgiehl opened this Pull Request on November 27th 2020 Member

Description:

The index actually differs from the one defined in the update script:
https://github.com/matomo-org/matomo/blob/1fa10c628c751d43b346a909e68833d26d5c08ff/core/Updates/4.0.0-b1.php#L105

Not sure if the index on name was on purpose. If so we need to limit the field or the index

fixes #16811

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@tsteur commented on November 27th 2020 Member

@diosmosis which one is the correct index? the one in the update script or the schema?

@diosmosis commented on November 27th 2020 Member

I don't think we want an index on name, not sure why that was in there.

This Pull Request was closed on November 27th 2020
Powered by GitHub Issue Mirror