Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust archive_invalidations index #16826

Merged
merged 1 commit into from Nov 27, 2020
Merged

Adjust archive_invalidations index #16826

merged 1 commit into from Nov 27, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 27, 2020

Description:

The index actually differs from the one defined in the update script:

matomo/core/Updates/4.0.0-b1.php

Line 105 in 1fa10c6

$migrations[] = $this->migration->db->addIndex('archive_invalidations', ['idsite', 'date1', 'period'], 'index_idsite_dates_period_name');

Not sure if the index on name was on purpose. If so we need to limit the field or the index

fixes #16811

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added this to the 4.0.2 milestone Nov 27, 2020
@sgiehl sgiehl added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Nov 27, 2020
@tsteur
Copy link
Member

tsteur commented Nov 27, 2020

@diosmosis which one is the correct index? the one in the update script or the schema?

@diosmosis
Copy link
Member

I don't think we want an index on name, not sure why that was in there.

@diosmosis diosmosis merged commit 0bda965 into 4.x-dev Nov 27, 2020
@diosmosis diosmosis deleted the fixindex branch November 27, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.2
Development

Successfully merging this pull request may close these issues.

Matomo 4 migration: Index column size too large
3 participants
@sgiehl @tsteur @diosmosis