@tsteur opened this Pull Request on November 27th 2020 Member

just testing our WP plugin with PHP8 and noticed this.

r: Required parameter $content follows optional parameter $overwrite => ServerFilesGenerator.php:104;

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
This Pull Request was closed on November 27th 2020
Powered by GitHub Issue Mirror