Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8 compatibility improvements #16823

Merged
merged 1 commit into from Nov 27, 2020
Merged

PHP8 compatibility improvements #16823

merged 1 commit into from Nov 27, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 27, 2020

just testing our WP plugin with PHP8 and noticed this.

r: Required parameter $content follows optional parameter $overwrite => ServerFilesGenerator.php:104;

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

just testing our WP plugin with PHP8 and noticed this. Will add some more fixes potentially.
@tsteur tsteur added this to the 4.0.2 milestone Nov 27, 2020
@tsteur tsteur added the Needs Review PRs that need a code review label Nov 27, 2020
@tsteur tsteur changed the title PHP8 compatibility issues PHP8 compatibility improvements Nov 27, 2020
@sgiehl sgiehl merged commit b66217b into 4.x-dev Nov 27, 2020
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 27, 2020
@sgiehl sgiehl deleted the php8fix branch December 15, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants