Improve token auth migration #16822
Merged
Improve token auth migration #16822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
reviewed
Nov 27, 2020
core/Updates/4.0.0-b1.php
Outdated
| @@ -269,6 +246,9 @@ public function doUpdate(Updater $updater) | |||
|
|
|||
| $updater->executeMigrations(__FILE__, $this->getMigrations($updater)); | |||
|
|
|||
| // just in case it was not executed manually by a user... | |||
| MigrateTokenAuths::migrate(); | |||
There was a problem hiding this comment.
Is this necessary? Since the migration is added above, if the user clicks 'Update', it will definitely run right? If so, this would be redundant. Or is there some way for the user to opt out of that specific migration running?
There was a problem hiding this comment.
true, it's not needed .will remove it now
|
Noticed the core:matomo4-migrate-token-auths command doesn't provide any output, maybe a 'Done.' message would be useful to have? |
diosmosis
approved these changes
Nov 27, 2020
|
Updated it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
as discussed. will basically look like this:
Review