Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP optimize is not a Matomo plugin #16820

Merged
merged 1 commit into from Nov 27, 2020
Merged

WP optimize is not a Matomo plugin #16820

merged 1 commit into from Nov 27, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 27, 2020

Just noticed wordpress found wp-optimize which has a plugin.json but a custom plugin.json and then it was throwing an exception that it's not a valid plugin name because of the dash.

Was only visible on the command line so far so might not be an issue. If this happens again I will find a better generic solution for it.

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

Just noticed wordpress found wp-optimize which has a plugin.json but a custom plugin.json and then it was throwing an exception that it's not a valid plugin name because of the dash.

Was only visible on the command line so far so might not be an issue. If this happens again I will find a better generic solution for it.
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 27, 2020
@tsteur tsteur added this to the 4.0.2 milestone Nov 27, 2020
@tsteur tsteur merged commit ca0b2c8 into 4.x-dev Nov 27, 2020
@tsteur tsteur deleted the wpoptimize branch November 27, 2020 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant