@sgiehl opened this Pull Request on November 26th 2020 Member

Description:

Instead of updating every single session we could also try UPDATE session SET id=SHA2(id, 512), but that method might be unavailable if mysql is not configured for SSL, causing the update to fail maybe. So guess it's better this way.

fixes #16798

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@tsteur commented on November 26th 2020 Member

Note: this test fails but also does in 4.x https://travis-ci.com/github/matomo-org/matomo/jobs/449214044#L1438

This Pull Request was closed on November 26th 2020
Powered by GitHub Issue Mirror