Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wikimedia/less.php instead of leafo/lessphp #16813

Merged
merged 4 commits into from Dec 10, 2020
Merged

Use wikimedia/less.php instead of leafo/lessphp #16813

merged 4 commits into from Dec 10, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 26, 2020

Description:

The resulting CSS seems to change slightly, but seems everything still works as expected.
Using this library also fixed an importing issue for custom plugin dirs that should have been visible through the now changed UI file 馃檲

fixes #16082

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added the Needs Review PRs that need a code review label Nov 26, 2020
@sgiehl sgiehl added this to the 4.1.0 milestone Nov 26, 2020
@diosmosis diosmosis merged commit d71e44c into 4.x-dev Dec 10, 2020
@diosmosis diosmosis deleted the lessphp branch December 10, 2020 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version "dev-php74-compat" of "leafo/lessphp" does no exist
2 participants