Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ExampleTheme plugin on update #16807

Merged
merged 2 commits into from Nov 26, 2020
Merged

Remove ExampleTheme plugin on update #16807

merged 2 commits into from Nov 26, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 26, 2020

We already deactivate the plugin but it looks like we actually need to fully remove the plugin. It should only be removed if it was not installed through git as in git we still have it.

fix #16804

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur
Remove ExampleTheme plugin on update
ed82fc7 
We already deactivate the plugin but it looks like we actually need to fully remove the plugin. It should only be removed if it was not installed through git as in git we still have it.
@tsteur
Update Version.php
614fe96
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 26, 2020
@tsteur tsteur added this to the 4.0.1 milestone Nov 26, 2020
@tsteur
Copy link
Member Author

tsteur commented Nov 26, 2020

Tests are passing

@diosmosis diosmosis merged commit c3cb221 into 4.x-dev Nov 26, 2020
@diosmosis diosmosis deleted the m16804 branch November 26, 2020 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.

Matomo 4.0.0 warns about "ExampleTheme requires Piwik <4.0.0-b1"
2 participants
@tsteur @diosmosis