Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let users configure a max actions per visit that should be recorded (available in TrackingSpamPrevention plugin) #16802

Closed
tsteur opened this issue Nov 25, 2020 · 1 comment
Labels
trackingspam For issues related to receiving tracking requests from spammers and bots.

Comments

@tsteur
Copy link
Member

tsteur commented Nov 25, 2020

I think this could go into a new plugin similar to #16794 . The plugin could be called like "TrackingSpamProtection" or similar. Could include this in core or on the marketplace.

A new UI system setting be great that lets you configure a max number of actions per visit. By default unlimited actions would be allowed. If the plugin is installed through the marketplace we could maybe set a max value of 500 or so.

The thought is that for most websites it's unrealistic that say more than 100 actions per visit are performed (or more than 50 or more than 500 ...). To prevent spammers sending hundreds or thousands of requests for one visit, we would ignore any new tracking request once the configured limit has been reached. It should be as easy as comparing configured value with visit_total_actions and be very fast.

As a result if a spamming attack happens, the DB will need less resources plus the data is not as messed up.

It should also be possible to have this setting set to "unlimited" actions per visit. We don't need to have this setting for now per site. We can always do this later (yes ideally it was per site). We should in the note mention though that this setting applies to all sites.

@tsteur tsteur added the trackingspam For issues related to receiving tracking requests from spammers and bots. label Nov 25, 2020
@tsteur tsteur changed the title New setting: Max Actions per visit New setting: Let users configure a max actions per visit that should be recorded Nov 25, 2020
@tsteur
Copy link
Member Author

tsteur commented Dec 23, 2020

@tsteur tsteur closed this as completed Dec 23, 2020
@mattab mattab changed the title New setting: Let users configure a max actions per visit that should be recorded Let users configure a max actions per visit that should be recorded (available in TrackingSpamPrevention plugin) Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trackingspam For issues related to receiving tracking requests from spammers and bots.
Projects
None yet
Development

No branches or pull requests

1 participant