Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pluginjson for custom dimensions + fix build #16799

Merged
merged 2 commits into from Nov 26, 2020
Merged

Add pluginjson for custom dimensions + fix build #16799

merged 2 commits into from Nov 26, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 25, 2020

fix #16786

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 25, 2020
@tsteur tsteur modified the milestones: 4.1.0, 4.0.1 Nov 25, 2020
@tsteur tsteur changed the title Add pluginjson for custom dimensions Add pluginjson for custom dimensions + fix build Nov 25, 2020
@tsteur
Copy link
Member Author

tsteur commented Nov 25, 2020

Also fixed the build in this PR. The new SEO UI test I haven't fixed though @sgiehl it seems to change the number of days every day.

The tests are otherwise passing so this should be good to merge

@tsteur tsteur mentioned this pull request Nov 26, 2020
Closed
9 tasks
@diosmosis diosmosis merged commit d9932ed into 4.x-dev Nov 26, 2020
@diosmosis diosmosis deleted the m16786 branch November 26, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.

No custom dimensions in Matomo 4.0.0
2 participants
@tsteur @diosmosis