Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use composer/ca-bundle for default CA bundle #16797

Merged
merged 1 commit into from Dec 17, 2020
Merged

use composer/ca-bundle for default CA bundle #16797

merged 1 commit into from Dec 17, 2020

Conversation

Findus23
Copy link
Member

As mentioned in #13743 (comment) a long time ago.

This should not change anything as composer/ca-bundle was already an indirect dependency.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@Findus23 Findus23 added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Nov 25, 2020
@Findus23 Findus23 added this to the 4.1.0 milestone Nov 25, 2020
@tsteur tsteur added the Needs Review PRs that need a code review label Nov 25, 2020
sgiehl
sgiehl reviewed Nov 26, 2020
View reviewed changes
composer.lock Outdated Show resolved Hide resolved
@sgiehl
Copy link
Member

sgiehl commented Dec 16, 2020

I've rebased the branch and resolved the conflicts. Should imho be good to merge now

@diosmosis diosmosis merged commit b76eb50 into 4.x-dev Dec 17, 2020
@diosmosis diosmosis deleted the use-composer-ca-bundle branch December 17, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl left review comments

Assignees
No one assigned
Labels
Needs Review PRs that need a code review Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Findus23 @sgiehl @diosmosis @tsteur