Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a period has no data, but raw data, show a message #16790

Closed
tsteur opened this issue Nov 24, 2020 · 3 comments · Fixed by #17380
Closed

When a period has no data, but raw data, show a message #16790

tsteur opened this issue Nov 24, 2020 · 3 comments · Fixed by #17380
Assignees
Labels
c: Onboarding For issues that make the experience of getting Matomo up and running better.
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented Nov 24, 2020

Conditions when to apply this:

  • For now only apply when "no segment" is select (report shows all visits)

When loading the reporting UI, or when selecting a different date, can we check in an API call if nb_visits=0? If that's the case, we also check if there's any visit during that period in log tables raw data. If that's the case, we could show an info message like this:

image

Where click on visits log would move the user to the "visits log". Could we also have a link that opens the date selector? Wording likely needs to be improved (didn't think too much about exact wording).

Maybe we would only do this extra API call if the date includes "today" as in other cases it should not be needed.

@tsteur tsteur added the c: Onboarding For issues that make the experience of getting Matomo up and running better. label Nov 24, 2020
@tsteur tsteur changed the title When a period has no data, but raw data has, show a message When a period has no data, but raw data, show a message Nov 24, 2020
@tsteur tsteur added this to the 4.1.0 milestone Nov 25, 2020
@mattab mattab modified the milestones: 4.1.0, 4.2.0 Dec 21, 2020
@mattab mattab modified the milestones: 4.2.0, 4.3.0 Feb 22, 2021
@flamisz flamisz assigned flamisz and unassigned flamisz Mar 17, 2021
@flamisz
Copy link
Contributor

flamisz commented Mar 18, 2021

Hi @tsteur, we already have a message like this:

Screen Shot 2021-03-18 at 1 30 45 PM

We'd like to improve this one by checking the raw data or we'd like to handle these things completely separately?

@tsteur
Copy link
Member Author

tsteur commented Mar 18, 2021

seems this was added as part of #13753

It seems to be only shown though when archiving was last executed more than a day ago and it's not shown to users with view access. The link to the set up archiving is also not 100% helpful because likely they have it already set up but they have some problem. That would be a different issue though.

I'm thinking we want to show a different notification if archiving was last run in less than a day ago. It would be also shown to view users. And rather than suggesting there might be a problem and adding a link we would say something like in the image from the issue description. And we would only show this message if there is actually raw data for the currently selected date period.

So it's a bit different as above message is shown when archiving hasn't run successfully in a while and there might be a problem. Vs in this case there is more than likely no problem, it's just that the archiving hasn't run yet.

Not sure if that's clear?

@flamisz
Copy link
Contributor

flamisz commented Mar 18, 2021

@tsteur thanks, yes it's clear now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Onboarding For issues that make the experience of getting Matomo up and running better.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants