Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GTM install guide to "no data tracked yet" page #16785

Merged
merged 3 commits into from Dec 10, 2020
Merged

Add GTM install guide to "no data tracked yet" page #16785

merged 3 commits into from Dec 10, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 24, 2020

Description:

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added the Needs Review PRs that need a code review label Nov 24, 2020
@tsteur tsteur added this to the 4.1.0 milestone Nov 24, 2020
@diosmosis diosmosis merged commit 7ae1285 into 4.x-dev Dec 10, 2020
@diosmosis diosmosis deleted the gtmguide branch December 10, 2020 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tsteur @sgiehl @diosmosis